Add tooltip for "Required Crafts" with shift #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
force-pushed
the
add-required-tooltip
branch
from
559ff8d to
7245ad6
Compare
Emilgardis
commented
Nov 10, 2025
| nei.bookmark.crafting_chain.missing=Missing Items | ||
| nei.bookmark.crafting_chain.output=Results | ||
| nei.bookmark.crafting_chain.remainder=Remainders | ||
| nei.bookmark.crafting_chain.needed=Required Crafts |
Comment on lines
+172
to
+177
| if (this.lastShiftKey) { | ||
| for (Map.Entry<BookmarkItem, Long> item : this.math.requiredAmount.entrySet()) { | ||
| if (item.getKey().type == BookmarkItem.BookmarkItemType.RESULT && item.getValue() != 0) | ||
| craftingNeeded.add(item.getKey().getItemStack(item.getValue())); | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
since I'm not familiar with this code base I'm unsure if this is the best way to do it, would also want to sort the entries in some kind of order, like most "furthest" away craft is sorted earlier.
There was a problem hiding this comment.
you could probably use toposort to do that
Dream-Master
added
the
🚧 Testing on Zeta
Member
|
@slprime can you help here or review it ? |
|
Functionally I"ll say it lgtm, but I can't comment about the code. 
|
slprime
approved these changes
Dec 28, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #656 by adding a new tooltip on shift that displays what items you need to craft